Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete setup.py #1001

Merged
merged 10 commits into from
Aug 1, 2023
Merged

Delete setup.py #1001

merged 10 commits into from
Aug 1, 2023

Conversation

michplunkett
Copy link
Collaborator

@michplunkett michplunkett commented Jul 31, 2023

Description of Changes

I looked around the application and we don't actually use the file at all, so I wiped it.

Tests and linting

  • This branch is up-to-date with the develop branch.
  • pytest passes on my local development environment.
  • pre-commit passes on my local development environment.

@michplunkett michplunkett changed the title Update setup.py Delete setup.py Aug 1, 2023
Copy link

@null-space-0 null-space-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if it's not called let's just get rid of it, it's just making things messy

Comment on lines -46 to -47
# Copy python script to initialize database.
COPY /usr/src/app/
Copy link
Collaborator Author

@michplunkett michplunkett Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deletion addresses the issue in this build: https://github.com/lucyparsons/OpenOversight/actions/runs/5732169896/job/15534595950

ERROR: failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: dockerfile parse error line 47: COPY requires at least two arguments, but only one was provided. Destination could not be determined
Error: buildx failed with: ERROR: failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: dockerfile parse error line 47: COPY requires at least two arguments, but only one was provided. Destination could not be determined

@michplunkett michplunkett merged commit 48199b7 into develop Aug 1, 2023
2 checks passed
@michplunkett michplunkett deleted the modify_setup branch August 1, 2023 22:01
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Sep 24, 2023
I looked around the application and we don't actually use the file at
all, so I wiped it.

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Sep 25, 2023
I looked around the application and we don't actually use the file at
all, so I wiped it.

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
AetherUnbound pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Oct 9, 2023
I looked around the application and we don't actually use the file at
all, so I wiped it.

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
AetherUnbound pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Oct 9, 2023
I looked around the application and we don't actually use the file at
all, so I wiped it.

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants